]> git.karo-electronics.de Git - karo-tx-linux.git/commit
Fix SET_VLAN_INGRESS_PRIORITY_CMD error return.
authorPatrick McHardy <kaber@trash.net>
Tue, 13 Nov 2007 08:13:37 +0000 (00:13 -0800)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 16 Nov 2007 16:27:37 +0000 (08:27 -0800)
commit9def747b654622c8ce0936ccb0f4670f978c138e
tree5b0758eae3a14652407b10f96aed59d1dace38b4
parentdae1e6e82707b560430ef0a9a24c57724cfdb8ae
Fix SET_VLAN_INGRESS_PRIORITY_CMD error return.

patch fffe470a803e7f7b74c016291e542a0162761209 in mainline.

[VLAN]: Fix SET_VLAN_INGRESS_PRIORITY_CMD ioctl

Based on report and patch by Doug Kehn <rdkehn@yahoo.com>:

vconfig returns the following error when attempting to execute the
set_ingress_map command:

vconfig: socket or ioctl error for set_ingress_map: Operation not permitted

In vlan.c, vlan_ioctl_handler for SET_VLAN_INGRESS_PRIORITY_CMD
sets err = -EPERM and calls vlan_dev_set_ingress_priority.
vlan_dev_set_ingress_priority is a void function so err remains
at -EPERM and results in the vconfig error (even though the ingress
map was set).

Fix by setting err = 0 after the vlan_dev_set_ingress_priority call.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/8021q/vlan.c