]> git.karo-electronics.de Git - karo-tx-linux.git/commit
rtlwifi: rtl8192cu: Fix duplicate if test
authorLarry Finger <Larry.Finger@lwfinger.net>
Tue, 18 Jun 2013 18:25:05 +0000 (13:25 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 22 Jul 2013 01:21:22 +0000 (18:21 -0700)
commit9e8e8fdf3d60235954e1452283b21e955e574b98
tree61c88905af8ce5cada2753201e8b5ee51dd65d20
parent85eb7ce1182a97ee66095a4fb1f8eae5171373c2
rtlwifi: rtl8192cu: Fix duplicate if test

commit 10d0b9030a3f86e1e26c710c7580524d7787d688 upstream.

A typo causes routine rtl92cu_phy_rf6052_set_cck_txpower() to test the
same condition twice. The problem was found using cppcheck-1.49, and the
proper fix was verified against the pre-mac80211 version of the code.

This patch was originally included as commit 1288aa4, but was accidentally
reverted in a later patch.

Reported-by: David Binderman <dcb314@hotmail.com> [original report]
Reported-by: Andrea Morello <andrea.merello@gmail.com> [report of accidental reversion]
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/wireless/rtlwifi/rtl8192cu/rf.c