]> git.karo-electronics.de Git - linux-beck.git/commit
lockdep: warn about lockdep disabling after kernel taint
authorFrederic Weisbecker <fweisbec@gmail.com>
Sat, 11 Apr 2009 01:17:17 +0000 (03:17 +0200)
committerIngo Molnar <mingo@elte.hu>
Sun, 12 Apr 2009 14:10:51 +0000 (16:10 +0200)
commit9eeba6138cefc0435695463ddadb0d95e0a6bcd2
treedaba646e5ddd27132e9679aa3eabec389bf4722e
parent066123a535927b3f17cac2305258cc71abdb0d92
lockdep: warn about lockdep disabling after kernel taint

Impact: provide useful missing info for developers

Kernel taint can occur in several situations such as warnings,
load of prorietary or staging modules, bad page, etc...

But when such taint happens, a developer might still be working on
the kernel, expecting that lockdep is still enabled. But a taint
disables lockdep without ever warning about it.
Such a kernel behaviour doesn't really help for kernel development.

This patch adds this missing warning.

Since the taint is done most of the time after the main message that
explain the real source issue, it seems safe to warn about it inside
add_taint() so that it appears at last, without hurting the main
information.

v2: Use a generic helper to disable lockdep instead of an
    open coded xchg().

Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
LKML-Reference: <1239412638-6739-1-git-send-email-fweisbec@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
include/linux/debug_locks.h
kernel/panic.c
lib/debug_locks.c