]> git.karo-electronics.de Git - linux-beck.git/commit
gpio/vt8500: memory cleanup missing
authorTony Prisk <linux@prisktech.co.nz>
Fri, 18 Jan 2013 04:58:22 +0000 (17:58 +1300)
committerGrant Likely <grant.likely@secretlab.ca>
Mon, 11 Feb 2013 22:21:29 +0000 (22:21 +0000)
commit9f01d30ee191a74f1e7a2ac0710f064f472d000a
tree7be3599e3068977c27a1cb0052d38f0fdb895f2f
parent362432aed5e5b497a8cf7b20c268ba71df93c045
gpio/vt8500: memory cleanup missing

This driver is missing a .remove callback, and the fail path on
probe is incomplete.

If an error occurs in vt8500_add_chips, gpio_base is not unmapped.
The driver is also ignoring the return value from this function so
if a chip fails to register it completes as successful.

Replaced pr_err with dev_err in vt8500_add_chips since the device is
available.

There is also no .remove callback defined so the function is added.

Signed-off-by: Tony Prisk <linux@prisktech.co.nz>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
drivers/gpio/gpio-vt8500.c