]> git.karo-electronics.de Git - karo-tx-linux.git/commit
drm/doc: Clarify mode_fixup vs. atomic_check a bit more
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 15 May 2017 09:11:36 +0000 (11:11 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 23 May 2017 14:36:06 +0000 (16:36 +0200)
commit9f800214731fddb0a99810bcd1af8d93d22076e0
tree97af8b91aca3d6309fb55acf46da8ec6cdefa39f
parent9de5d4a61cc2a99634e3b51bda0f8e2fdd8f4287
drm/doc: Clarify mode_fixup vs. atomic_check a bit more

Brought up by both Laurent and Andrzej when reviewing the new
->mode_valid hooks. Since mode_fixup is just a simpler version of the
much more generic atomic_check we can't really unify it with
mode_valid. Most drivers should probably switch their current
mode_fixup code to either the new mode_valid or the atomic_check
hooks, but e.g. that doesn't exist yet for bridges, and for CRTCs the
situation is a bit more complicated. Hence there's no clear
equivalence between mode_fixup and mode_valid, even if it looks like
that at first glance.

v2: Fix accidental double-dot (Adnrzej).

Cc: Andrzej Hajda <a.hajda@samsung.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Jose Abreu <Jose.Abreu@synopsys.com>
Reviewed-by: Jose Abreu <joabreu@synopsys.com>
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20170515091136.26307-2-daniel.vetter@ffwll.ch
include/drm/drm_modeset_helper_vtables.h