]> git.karo-electronics.de Git - karo-tx-linux.git/commit
zram: Fix deadlock bug in partial read/write
authorMinchan Kim <minchan@kernel.org>
Wed, 30 Jan 2013 02:41:39 +0000 (11:41 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 28 Feb 2013 13:38:31 +0000 (05:38 -0800)
commit9ff7a0c89c9331701fbd906b4e3e7308820f0e56
treec5d6d7e29fa76f76fa7e1ec9808945da1a087b6c
parent49626fbb0360332e40fd76a48cb2ba876d6134ad
zram: Fix deadlock bug in partial read/write

commit 7e5a5104c6af709a8d97d5f4711e7c917761d464 upstream.

Now zram allocates new page with GFP_KERNEL in zram I/O path
if IO is partial. Unfortunately, It may cause deadlock with
reclaim path like below.

write_page from fs
fs_lock
allocation(GFP_KERNEL)
reclaim
pageout
write_page from fs
fs_lock <-- deadlock

This patch fixes it by using GFP_NOIO.  In read path, we
reorganize code flow so that kmap_atomic is called after the
GFP_NOIO allocation.

Acked-by: Jerome Marchand <jmarchand@redhat.com>
Acked-by: Nitin Gupta <ngupta@vflare.org>
[ penberg@kernel.org: don't use GFP_ATOMIC ]
Signed-off-by: Pekka Enberg <penberg@kernel.org>
Signed-off-by: Minchan Kim <minchan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/zram/zram_drv.c