]> git.karo-electronics.de Git - karo-tx-linux.git/commit
drm/amdgpu: fix sched fence slab teardown
authorGrazvydas Ignotas <notasas@gmail.com>
Sun, 23 Oct 2016 18:31:44 +0000 (21:31 +0300)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 24 Oct 2016 21:00:38 +0000 (17:00 -0400)
commita053fb7e512c77f0742bceb578b10025256e1911
treef93b3190e71ef43e1830f41a3feb932daaa89e5d
parent9dc79965b21967caebde575f5f5d8bf1aa2c23ab
drm/amdgpu: fix sched fence slab teardown

To free fences, call_rcu() is used, which calls amd_sched_fence_free()
after a grace period. During teardown, there is no guarantee all
callbacks have finished, so sched_fence_slab may be destroyed before
all fences have been freed. If we are lucky, this results in some slab
warnings, if not, we get a crash in one of rcu threads because callback
is called after amdgpu has already been unloaded.

Fix it with a rcu_barrier().

Fixes: 189e0fb76304 ("drm/amdgpu: RCU protected amd_sched_fence_release")
Acked-by: Chunming Zhou <david1.zhou@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/scheduler/gpu_scheduler.c