]> git.karo-electronics.de Git - linux-beck.git/commit
[media] v4l2-ioctl: fix incorrect error code if VIDIOC_DBG_G/S_REGISTER are unsupported
authorHans Verkuil <hverkuil@xs4all.nl>
Sat, 8 Jan 2011 12:53:32 +0000 (09:53 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Wed, 19 Jan 2011 13:45:13 +0000 (11:45 -0200)
commita1198ccf9c52922e66a3372b0045ebe335a127dd
tree246bd2f8cbba0b71bf63cc2c07495e7172685dda
parent4c775902252b06673cf26a33834842f1fec3fe3e
[media] v4l2-ioctl: fix incorrect error code if VIDIOC_DBG_G/S_REGISTER are unsupported

The ioctls VIDIOC_DBG_S_REGISTER and VIDIOC_DBG_G_REGISTER should return -EINVAL
if the driver didn't implement them. Currently they return -EPERM if called as
non-root user. However, this check should only be done if the driver actually
implemented these ioctls. Otherwise, just return -EINVAL as we do with all
unimplemented ioctls.

This bug make the v4l2-compliance test suite fail.

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/v4l2-ioctl.c