]> git.karo-electronics.de Git - linux-beck.git/commit
iio: accel: sca3000_core: avoid potentially uninitialized variable
authorArnd Bergmann <arnd@arndb.de>
Thu, 22 Sep 2016 09:43:42 +0000 (11:43 +0200)
committerJonathan Cameron <jic23@kernel.org>
Thu, 22 Sep 2016 17:36:57 +0000 (18:36 +0100)
commita1427af59977894d20b1b5ea61f4b2856c7d1833
tree2597f5288e9679441db2c4d903ca806ced9f35a4
parenta04c28d0797bb9b8743efe814672dea8e3b91c55
iio: accel: sca3000_core: avoid potentially uninitialized variable

The newly added __sca3000_get_base_freq function handles all valid
modes of the SCA3000_REG_ADDR_MODE register, but gcc notices
that any other value (i.e. 0x00) causes the base_freq variable to
not get initialized:

drivers/staging/iio/accel/sca3000_core.c: In function 'sca3000_write_raw':
drivers/staging/iio/accel/sca3000_core.c:527:23: error: 'base_freq' may be used uninitialized in this function [-Werror=maybe-uninitialized]

This adds explicit error handling for unexpected register values,
to ensure this cannot happen.

Fixes: e0f3fc9b47e6 ("iio: accel: sca3000_core: implemented IIO_CHAN_INFO_SAMP_FREQ")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
drivers/staging/iio/accel/sca3000_core.c