]> git.karo-electronics.de Git - linux-beck.git/commit
clocksource: nps: avoid maybe-uninitialized warning
authorArnd Bergmann <arnd@arndb.de>
Tue, 22 Nov 2016 14:33:44 +0000 (15:33 +0100)
committerVineet Gupta <vgupta@synopsys.com>
Wed, 30 Nov 2016 19:54:25 +0000 (11:54 -0800)
commita26b0d4962c7daf91d942a917c71c20e164b687a
treea20bdb7696eac194d005226eae15fd505258d522
parent60263dcd821b9558ea08b112d9d31ffbe3ac643f
clocksource: nps: avoid maybe-uninitialized warning

We get a harmless false-positive warning with the newly added nps
clocksource driver:

drivers/clocksource/timer-nps.c: In function 'nps_setup_clocksource':
drivers/clocksource/timer-nps.c:102:6: error: 'nps_timer1_freq' may be used uninitialized in this function [-Werror=maybe-uninitialized]

Gcc here fails to identify that IS_ERR() is only true if PTR_ERR()
has a nonzero value. Using PTR_ERR_OR_ZERO() to convert the result
first makes this obvious and shuts up the warning.

Fixes: 0ee4d9922df5 ("clocksource: Add clockevent support to NPS400 driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
drivers/clocksource/timer-nps.c