]> git.karo-electronics.de Git - karo-tx-linux.git/commit
ixgbe: fix SFF data dumps of SFP+ modules
authorEmil Tantilov <emil.s.tantilov@intel.com>
Wed, 29 May 2013 06:23:10 +0000 (06:23 +0000)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Wed, 31 Jul 2013 00:56:04 +0000 (17:56 -0700)
commita4b6fc6bc61e6aeb24af73c5b195a6aec27d88ff
tree8f48363c496ddb5fa8cce721f3c539ae701c5159
parent3dcc2f4142610cc7212a757348d45f1e815927c9
ixgbe: fix SFF data dumps of SFP+ modules

This patch fixes several issues with the previous implementation of the
SFF data dump of SFP+ modules:

- removed the __IXGBE_READ_I2C flag - I2C access locking is handled in the
  HW specific routines

- fixed the read loop to read data from ee->offset to ee->len

- the reads fail if __IXGBE_IN_SFP_INIT is set in the process - this is
  needed because on some HW I2C operations can take long time and disrupt
  the SFP and link detection process

Signed-off-by: Emil Tantilov <emil.s.tantilov@intel.com>
Reported-by: Ben Hutchings <bhutchings@solarflare.com>
Tested-by: Phil Schmitt <phillip.j.schmitt@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/ixgbe/ixgbe.h
drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c