]> git.karo-electronics.de Git - linux-beck.git/commit
enic: Bug Fix: Fix hardware descriptor reads
authorVasanthy Kolluri <vkolluri@cisco.com>
Thu, 18 Mar 2010 16:19:44 +0000 (16:19 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 19 Mar 2010 04:22:47 +0000 (21:22 -0700)
commita55a603dae47a1ea4fbfad3a3a428ea7a0900ab6
treee5a0526197efe4afb24443a2b918a8908ce11a43
parentba7e94a44afbbf4c494e00b844f7bbfb144e7f6d
enic: Bug Fix: Fix hardware descriptor reads

The last bit written to a completion descriptor by hardware is the color
bit. Driver must read all other descriptor fields only after reading the
color bit to avoid reading stale descriptor fields.  There is a rmb() after
reading the color bit to avoid any compiler/cpu reordering of the reads.
The color bit is the generation bit that toggles each pass through the
completion descriptor ring.

Signed-off-by: Scott Feldman <scofeldm@cisco.com>
Signed-off-by: Vasanthy Kolluri <vkolluri@cisco.com>
Signed-off-by: Roopa Prabhu <roprabhu@cisco.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/enic/cq_enet_desc.h
drivers/net/enic/enic.h