]> git.karo-electronics.de Git - karo-tx-linux.git/commit
x86: fix mmap random address range
authorLudwig Nussel <ludwig.nussel@suse.de>
Wed, 16 Nov 2011 23:41:01 +0000 (10:41 +1100)
committerStephen Rothwell <sfr@canb.auug.org.au>
Fri, 18 Nov 2011 03:49:40 +0000 (14:49 +1100)
commita59364a66a8409af12fd2300791888a45cb3b2d2
tree3d66121f3f05a22e10bf9169e80f025b0a5aae90
parentee07ab2e5772632b7d60747fbe10cf8780d0d5fb
x86: fix mmap random address range

On x86_32 casting the unsigned int result of get_random_int() to long may
result in a negative value.  On x86_32 the range of mmap_rnd() therefore
was -255 to 255.  The 32bit mode on x86_64 used 0 to 255 as intended.

The bug was introduced by 675a081 ("x86: unify mmap_{32|64}.c") in January
2008.

Signed-off-by: Ludwig Nussel <ludwig.nussel@suse.de>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Harvey Harrison <harvey.harrison@gmail.com>
Cc: <stable@kernel.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
arch/x86/mm/mmap.c