]> git.karo-electronics.de Git - karo-tx-linux.git/commit
cifs: when server doesn't set CAP_LARGE_READ_X, cap default rsize at MaxBufferSize
authorJeff Layton <jlayton@redhat.com>
Mon, 2 Jul 2012 11:24:25 +0000 (07:24 -0400)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 12 Jul 2012 03:32:17 +0000 (04:32 +0100)
commita606d577a42b8d3333fb604cb93959e421d4bef3
tree83a0328d91be60944e36fe622ef0983d4606894e
parent518c75d289bfd41eadf8c55df1dc96a8e1779232
cifs: when server doesn't set CAP_LARGE_READ_X, cap default rsize at MaxBufferSize

commit ec01d738a1691dfc85b96b9f796020267a7be577 upstream.

When the server doesn't advertise CAP_LARGE_READ_X, then MS-CIFS states
that you must cap the size of the read at the client's MaxBufferSize.
Unfortunately, testing with many older servers shows that they often
can't service a read larger than their own MaxBufferSize.

Since we can't assume what the server will do in this situation, we must
be conservative here for the default. When the server can't do large
reads, then assume that it can't satisfy any read larger than its
MaxBufferSize either.

Luckily almost all modern servers can do large reads, so this won't
affect them. This is really just for older win9x and OS/2 era servers.
Also, note that this patch just governs the default rsize. The admin can
always override this if he so chooses.

Reported-by: David H. Durgee <dhdurgee@acm.org>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steven French <sfrench@w500smf.(none)>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
fs/cifs/connect.c