]> git.karo-electronics.de Git - karo-tx-linux.git/commit
mac80211: delete AddBA response timer
authorJohannes Berg <johannes.berg@intel.com>
Tue, 5 Oct 2010 19:40:33 +0000 (21:40 +0200)
committerAndi Kleen <ak@linux.intel.com>
Tue, 14 Dec 2010 22:40:02 +0000 (23:40 +0100)
commita664846f7362bd6b9cf6f1e407dd86daa963da97
tree33f9901a20064cea029b3f3fe3bc6be754c6d188
parenta171652459e33373b16fe9d48e200aaa359010b8
mac80211: delete AddBA response timer

commit 44271488b91c9eecf249e075a1805dd887e222d2 upstream.

We never delete the addBA response timer, which
is typically fine, but if the station it belongs
to is deleted very quickly after starting the BA
session, before the peer had a chance to reply,
the timer may fire after the station struct has
been freed already. Therefore, we need to delete
the timer in a suitable spot -- best when the
session is being stopped (which will happen even
then) in which case the delete will be a no-op
most of the time.

I've reproduced the scenario and tested the fix.

This fixes the crash reported at
http://mid.gmane.org/4CAB6F96.6090701@candelatech.com

Reported-by: Ben Greear <greearb@candelatech.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
net/mac80211/agg-tx.c