]> git.karo-electronics.de Git - karo-tx-linux.git/commit
watchdog: sp5100_tco: Fix wrong indirect I/O access for getting value of reserved...
authorTakahisa Tanaka <mc74hc00@gmail.com>
Mon, 14 Jan 2013 02:01:57 +0000 (11:01 +0900)
committerWim Van Sebroeck <wim@iguana.be>
Wed, 30 Jan 2013 19:10:35 +0000 (20:10 +0100)
commita6e26b1369b34760ca5e1f16039c9018bf68ce7e
tree344291158d2e64c50084e28217e0944381672fed
parent42b0dfcf92c51c87f4d1a41ed8728707460ce889
watchdog: sp5100_tco: Fix wrong indirect I/O access for getting value of reserved bits

In case of SB800 or later chipset and re-programming MMIO address(*),
sp5100_tco module may read incorrect value of reserved bit, because the module
reads a value from an incorrect I/O address. However, this bug doesn't cause
a problem, because when re-programming MMIO address, by chance the module
writes zero (this is BIOS's default value) to the low three bits of register.
* In most cases, PC with SB8x0 or later chipset doesn't need to re-programming
  MMIO address, because such PC can enable AcpiMmio and can use 0xfed80b00 for
  watchdog register base address.

This patch fixes this bug.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=43176
Signed-off-by: Takahisa Tanaka <mc74hc00@gmail.com>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
drivers/watchdog/sp5100_tco.c