]> git.karo-electronics.de Git - karo-tx-linux.git/commit
rcu: Make rcu_assign_pointer() unconditionally insert a memory barrier
authorEric Dumazet <eric.dumazet@gmail.com>
Mon, 1 Aug 2011 05:09:25 +0000 (22:09 -0700)
committerPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Wed, 10 Aug 2011 02:28:41 +0000 (19:28 -0700)
commita7590ddfc2c855e75111ef18147a86578fe136e4
tree43c1866f5a27b77df2357435c195c438f4a4413d
parent4fafac664e87c670fe6345366f99c88b279c1070
rcu: Make rcu_assign_pointer() unconditionally insert a memory barrier

Recent changes to gcc give warning messages on rcu_assign_pointers()'s
checks that allow it to determine when it is OK to omit the memory
barrier.  Stephen Hemminger tried a number of gcc tricks to silence
this warning, but #pragmas and CPP macros do not work together in the
way that would be required to make this work.

However, we now have RCU_INIT_POINTER(), which already omits this
memory barrier, and which therefore may be used when assigning NULL to
an RCU-protected pointer that is accessible to readers.  This commit
therefore makes rcu_assign_pointer() unconditionally emit the memory
barrier.

Reported-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Acked-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
include/linux/rcupdate.h