]> git.karo-electronics.de Git - karo-tx-linux.git/commit
batman-adv: fix skb->data assignment
authorAntonio Quartulli <ordex@autistici.org>
Tue, 19 Jun 2012 09:26:39 +0000 (09:26 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 16 Jul 2012 16:04:11 +0000 (09:04 -0700)
commita7faba5c5263f9d8a31b3f542a0504552fa80932
tree614201eeddf946308faffefa896db58f68c000b1
parent0d84f6e5ba73f0b2ef3af8e5c1f96b8ab8ecff6f
batman-adv: fix skb->data assignment

commit 2c995ff892313009e336ecc8ec3411022f5b1c39 upstream.

skb_linearize(skb) possibly rearranges the skb internal data and then changes
the skb->data pointer value. For this reason any other pointer in the code that
was assigned skb->data before invoking skb_linearise(skb) must be re-assigned.

In the current tt_query message handling code this is not done and therefore, in
case of skb linearization, the pointer used to handle the packet header ends up
in pointing to free'd memory.

This bug was introduced by a73105b8d4c765d9ebfb664d0a66802127d8e4c7
(batman-adv: improved client announcement mechanism)

Signed-off-by: Antonio Quartulli <ordex@autistici.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/batman-adv/routing.c