]> git.karo-electronics.de Git - karo-tx-linux.git/commit
mtd: nand: allow NAND_NO_SUBPAGE_WRITE to be set from driver
authorBrian Norris <computersforpeace@gmail.com>
Fri, 13 Jul 2012 16:28:24 +0000 (09:28 -0700)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 30 Oct 2012 23:26:28 +0000 (23:26 +0000)
commita8cfa724f6059e312e7a10f3116f4d028842d73c
treeb45340e757529a4a38d69e88f2b2194a717d15dc
parent04f2ad7734c4446f99a2c42503d6d94cf7271a8b
mtd: nand: allow NAND_NO_SUBPAGE_WRITE to be set from driver

commit bf7a01bf7987b63b121d572b240c132ec44129c4 upstream.

The NAND_CHIPOPTIONS_MSK has limited utility and is causing real bugs. It
silently masks off at least one flag that might be set by the driver
(NAND_NO_SUBPAGE_WRITE). This breaks the GPMI NAND driver and possibly
others.

Really, as long as driver writers exercise a small amount of care with
NAND_* options, this mask is not necessary at all; it was only here to
prevent certain options from accidentally being set by the driver. But the
original thought turns out to be a bad idea occasionally. Thus, kill it.

Note, this patch fixes some major gpmi-nand breakage.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Tested-by: Huang Shijie <shijie8@gmail.com>
Cc: stable@vger.kernel.org
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
[Brian Norris: This is a backport for v3.2 stable.]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/mtd/nand/nand_base.c
include/linux/mtd/nand.h