]> git.karo-electronics.de Git - karo-tx-linux.git/commit
Fix GFP_KERNEL with preemption disabled in fib_trie
authorRobert Olsson <robert.olsson@its.uu.se>
Sat, 17 Mar 2007 01:30:13 +0000 (18:30 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 23 Mar 2007 19:49:24 +0000 (12:49 -0700)
commitaa2bb55bbc1e890e1c1fefe72a953c476cb867a3
treec57457226add8631bb09ff811b7a71d79d8d853b
parent380974c0843a390d460446f79c5dea3b56046e66
Fix GFP_KERNEL with preemption disabled in fib_trie

[IPV4]: Do not disable preemption in trie_leaf_remove().

Hello, Just discussed this Patrick...

We have two users of trie_leaf_remove, fn_trie_flush and fn_trie_delete
both are holding RTNL. So there shouldn't be need for this preempt stuff.
This is assumed to a leftover from an older RCU-take.

> Mhh .. I think I just remembered something - me incorrectly suggesting
> to add it there while we were talking about this at OLS :) IIRC the
> idea was to make sure tnode_free (which at that time didn't use
> call_rcu) wouldn't free memory while still in use in a rcu read-side
> critical section. It should have been synchronize_rcu of course,
> but with tnode_free using call_rcu it seems to be completely
> unnecessary. So I guess we can simply remove it.

Signed-off-by: Robert Olsson <robert.olsson@its.uu.se>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/ipv4/fib_trie.c