]> git.karo-electronics.de Git - linux-beck.git/commit
mtd: docg4: fix oob reads
authorMike Dunn <mikedunn@newsguy.com>
Wed, 11 Jul 2012 18:08:19 +0000 (11:08 -0700)
committerDavid Woodhouse <David.Woodhouse@intel.com>
Sat, 29 Sep 2012 13:53:46 +0000 (14:53 +0100)
commitaa6d01fa435a6f701128829f8d9d04208fd53176
tree93deac9767a7613a5c0e081b08bb29cfa10e6f67
parent036a1ac1f4ac8cdfed4574738c63aba2e81a13e4
mtd: docg4: fix oob reads

This patch does two closely related things:

(1) Currently the ecc.read_page() method does not fill the nand->oob_poi buffer
with the oob data, but instead reads oob into a local buffer.  Fix this by
filling the oob_poi buffer instead of a local buffer.  The 'oob_required'
argument is quietly ignored; the device must always read oob after the page
data, and it is presumed that there's no harm in filling oob_poi, even when not
explicitly requested.

(2) Always read oob from the device in ecc.read_oob(), instead of copying it
from a local buffer under some circumstances.

Signed-off-by: Mike Dunn <mikedunn@newsguy.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
drivers/mtd/nand/docg4.c