]> git.karo-electronics.de Git - karo-tx-linux.git/commit
[SCSI] zfcp: return early from slave_destroy if slave_alloc returned early
authorSteffen Maier <maier@linux.vnet.ibm.com>
Fri, 18 Nov 2011 19:00:40 +0000 (20:00 +0100)
committerJames Bottomley <JBottomley@Parallels.com>
Mon, 12 Dec 2011 15:36:43 +0000 (19:36 +0400)
commitac33563b9f09fd644d840f2e6d271e7f18b2a726
treebbaf28b480018835fb61db1dd13ce8bd4d4e8b97
parent242a5cd655cccc7e135f588754f76fa1488e964c
[SCSI] zfcp: return early from slave_destroy if slave_alloc returned early

zfcp_scsi_slave_destroy erroneously always tried to finish its task
even if the corresponding previous zfcp_scsi_slave_alloc returned
early. This can lead to kernel page faults on accessing uninitialized
fields of struct zfcp_scsi_dev in zfcp_erp_lun_shutdown_wait. Take the
port field of the struct to determine if slave_alloc returned early.

This zfcp bug is exposed by 4e6c82b (in turn fixing f7c9c6b to be
compatible with 21208ae) which can call slave_destroy for a
corresponding previous slave_alloc that did not finish.

This patch is based on James Bottomley's fix suggestion in
http://www.spinics.net/lists/linux-scsi/msg55449.html.

Signed-off-by: Steffen Maier <maier@linux.vnet.ibm.com>
Cc: <stable@kernel.org> #2.6.38+
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
drivers/s390/scsi/zfcp_scsi.c