]> git.karo-electronics.de Git - linux-beck.git/commit
[SCSI] be2iscsi: Fix possible reentrancy issue in be_iopoll
authorShlomo Pongratz <shlomop@mellanox.com>
Sat, 6 Apr 2013 03:38:36 +0000 (20:38 -0700)
committerJames Bottomley <JBottomley@Parallels.com>
Thu, 2 May 2013 15:17:54 +0000 (08:17 -0700)
commitad3f428e0fbab1f306cbc22340e9f7672a49147f
treeacdf67e8fb630712b238d6ab32da92eeed741637
parent533c165fa81d2c5f36adf41a07efeef0e4822300
[SCSI] be2iscsi: Fix possible reentrancy issue in be_iopoll

The driver creates "NAPI" context per core which is fine,
however the above routine declares the ret variable as static!
Thus there is only one instance of this variable!
When this routine is called from more than one thread of execution,
than the result is unpredictable.

         static unsigned int ret;
         .....

         ret = beiscsi_process_cq(pbe_eq);
                 <--------Another thread can enter here and change "ret".
         if (ret < budget) {
                ....
         }
                 <--------Another thread can enter here and change "ret".
         return ret;

Fix - remove the "static"

Signed-off-by: Shlomo Pongratz <shlomop@mellanox.com>
Signed-off-by: Jayamohan Kallickal <jayamohan.kallickal@emulex.com>
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
drivers/scsi/be2iscsi/be_main.c