]> git.karo-electronics.de Git - linux-beck.git/commit
pinctrl: single: fix infinite loop caused by bad mask
authorTomi Valkeinen <tomi.valkeinen@ti.com>
Thu, 9 Jan 2014 12:50:29 +0000 (14:50 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 15 Jan 2014 07:31:53 +0000 (08:31 +0100)
commitad5d25fef8f9459a9f67ec5fbae94287fdea3247
treecde8521539c7cb408ffb7c0c7eb5a47c3ec1532b
parentdd4c2b3cb39da587fc1e5a9315d4d894a83ec481
pinctrl: single: fix infinite loop caused by bad mask

commit 4e7e8017a80e1 (pinctrl: pinctrl-single:
enhance to configure multiple pins of different modules) improved
support for pinctrl-single,bits option, but also caused a regression
in parsing badly configured mask data.

If the masks in DT data are not quite right,
pcs_parse_bits_in_pinctrl_entry() can end up in an infinite loop,
trashing memory at the same time.

Add a check to verify that each loop actually removes bits from the
'mask', so that the loop can eventually end.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-single.c