]> git.karo-electronics.de Git - linux-beck.git/commit
drm/i915/skl: Don't clear all watermarks when updating. (v2)
authorBob Paauwe <bob.j.paauwe@intel.com>
Tue, 21 Jul 2015 17:42:53 +0000 (10:42 -0700)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 22 Sep 2015 15:10:53 +0000 (17:10 +0200)
commitadda50b8b32bd559906d82fa32caeaf6c9306f59
treed0e2a49fcc2e7a32d648931d0814e2dfe85e3e20
parent25e1793f6c642604b13e33bc81a9c8d48d652c86
drm/i915/skl: Don't clear all watermarks when updating. (v2)

Clearing the watermarks for all pipes/planes when updating the
watermarks for a single CRTC change seems like the wrong thing to
do here. As is, this code will ony update any pipe/plane watermarks
that need updating and leave the remaining set to zero.  Later, the
watermark checks in check_wm_state() will flag these zero'd out pipe/plane
watermarks and throw errors.

By clearing only the watermark values associated with the specific crtc
the other watermark values may remain unchanged.

v2: Make sure all the dirty flags are cleared. Damien
    Clear all values assoicated with crtc/pipe being updated.  Damien

Signed-off-by: Bob Paauwe <bob.j.paauwe@intel.com>
Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_pm.c