]> git.karo-electronics.de Git - karo-tx-linux.git/commit
iwlwifi: mvm: fix firmware debug restart recording
authorEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Wed, 29 Mar 2017 07:21:09 +0000 (10:21 +0300)
committerLuca Coelho <luciano.coelho@intel.com>
Mon, 5 Jun 2017 18:47:08 +0000 (21:47 +0300)
commitaddce854f164a68da9cb158e2e7e447705068549
tree0345ee7ae8d93ff756008b308acb893707bee272
parentd9954405758a0cbbe258d9b4d4dc12a06fa48a28
iwlwifi: mvm: fix firmware debug restart recording

When we want to stop the recording of the firmware debug
and restart it later without reloading the firmware we
don't need to resend the configuration that comes with
host commands.
Sending those commands confused the hardware and led to
an NMI 0x66.

Change the flow as following:
* read the relevant registers (DBGC_IN_SAMPLE, DBGC_OUT_CTRL)
* clear those registers
* wait for the hardware to complete its write to the buffer
* get the data
* restore the value of those registers (to restart the
  recording)

For early start (where the configuration is already
compiled in the firmware), we don't need to set those
registers after the firmware has been loaded, but only
when we want to restart the recording without having
restarted the firmware.

Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
drivers/net/wireless/intel/iwlwifi/iwl-prph.h
drivers/net/wireless/intel/iwlwifi/mvm/fw-dbg.c
drivers/net/wireless/intel/iwlwifi/mvm/mvm.h
drivers/net/wireless/intel/iwlwifi/mvm/ops.c