]> git.karo-electronics.de Git - karo-tx-linux.git/commit
ext4_{set,clear}_bit() is defined as __test_and_{set,clear}_bit_le() for
authorAkinobu Mita <akinobu.mita@gmail.com>
Tue, 26 Jul 2011 10:14:46 +0000 (20:14 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Tue, 2 Aug 2011 05:14:20 +0000 (15:14 +1000)
commitb1f8f8906e0d16f2c441e5be8a7d63b56a908c09
treed71263ad062e6f659a9438a66680381d2bea5391
parent647eb2c57e8c8fdd5d13e3f7a72f5d016871a2a7
ext4_{set,clear}_bit() is defined as __test_and_{set,clear}_bit_le() for
ext4.  Only two ext4_{set,clear}_bit() calls check the return value.  The
rest of calls ignore the return value and they can be replaced with
__{set,clear}_bit_le().

This changes ext4_{set,clear}_bit() from __test_and_{set,clear}_bit_le()
to __{set,clear}_bit_le() and introduces ext4_test_and_{set,clear}_bit()
for the two places where old bit needs to be returned.

This ext4_{set,clear}_bit() change is considered safe, because if someone
uses these macros without noticing the change, new ext4_{set,clear}_bit
don't have return value and causes compiler errors where the return value
is used.

This also removes unused ext4_find_first_zero_bit().

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
fs/ext4/ext4.h
fs/ext4/ialloc.c