]> git.karo-electronics.de Git - karo-tx-linux.git/commit
drm/i915/vlv: Disable HPD in valleyview_crt_detect_hotplug()
authorLyude <cpaul@redhat.com>
Tue, 21 Jun 2016 21:03:43 +0000 (17:03 -0400)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 14 Jul 2016 20:06:11 +0000 (22:06 +0200)
commitb236d7c8421969ac0693fc571e47ee5c2a62fb90
treeff8053bce8d1162f03cae1603e0cd39a4991e877
parent9504a89247595b6c066c68aea0c34af1fc78d021
drm/i915/vlv: Disable HPD in valleyview_crt_detect_hotplug()

One of the things preventing us from using polling is the fact that
calling valleyview_crt_detect_hotplug() when there's a VGA cable
connected results in sending another hotplug. With polling enabled when
HPD is disabled, this results in a scenario like this:

- We enable power wells and reset the ADPA
- output_poll_exec does force probe on VGA, triggering a hpd
- HPD handler waits for poll to unlock dev->mode_config.mutex
- output_poll_exec shuts off the ADPA, unlocks dev->mode_config.mutex
- HPD handler runs, resets ADPA and brings us back to the start

This results in an endless irq storm getting sent from the ADPA
whenever a VGA connector gets detected in the middle of polling.

Somewhat based off of the "drm/i915: Disable CRT HPD around force
trigger" patch Ville Syrjälä sent a while back

Cc: stable@vger.kernel.org
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Lyude <cpaul@redhat.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/i915_drv.h
drivers/gpu/drm/i915/intel_crt.c
drivers/gpu/drm/i915/intel_hotplug.c