]> git.karo-electronics.de Git - karo-tx-linux.git/commit
serial/imx: read cts state only after acking cts change irq
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Mon, 11 Apr 2011 08:59:09 +0000 (10:59 +0200)
committerPaul Gortmaker <paul.gortmaker@windriver.com>
Wed, 14 Mar 2012 14:57:24 +0000 (10:57 -0400)
commitb2863898d0cac6b178b62004250a4d2bd992921f
tree79f775386d2fe7d3bbf86d21189c2b70cf85b8c6
parent0435c7f0719a6e7f372d405dee61728058409ca1
serial/imx: read cts state only after acking cts change irq

commit 5680e94148a86e8c31fdc5cb0ea0d5c6810c05b0 upstream.

If cts changes between reading the level at the cts input (USR1_RTSS)
and acking the irq (USR1_RTSD) the last edge doesn't generate an irq and
uart_handle_cts_change is called with a outdated value for cts.

The race was introduced by commit

ceca629 ([ARM] 2971/1: i.MX uart handle rts irq)

[PG: file in drivers/serial not drivers/tty/serial in .34]

Reported-by: Arwed Springer <Arwed.Springer@de.trumpf.com>
Tested-by: Arwed Springer <Arwed.Springer@de.trumpf.com>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
drivers/serial/imx.c