]> git.karo-electronics.de Git - karo-tx-linux.git/commit
drop_monitor: Make updating data->skb smp safe
authorNeil Horman <nhorman@tuxdriver.com>
Fri, 27 Apr 2012 10:11:49 +0000 (10:11 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 2 Oct 2012 16:47:42 +0000 (09:47 -0700)
commitb2f89a7caf4491dba4086663139e6fbc1ab59711
treea7dd1f6f9aaee9beb434046bd5eae4b0bc996259
parent34c0bc428c081c314c4b4ebf6c0fd335cf53c133
drop_monitor: Make updating data->skb smp safe

commit 3885ca785a3618593226687ced84f3f336dc3860 upstream.

Eric Dumazet pointed out to me that the drop_monitor protocol has some holes in
its smp protections.  Specifically, its possible to replace data->skb while its
being written.  This patch corrects that by making data->skb an rcu protected
variable.  That will prevent it from being overwritten while a tracepoint is
modifying it.

Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
CC: David Miller <davem@davemloft.net>
Acked-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Cc: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/core/drop_monitor.c