]> git.karo-electronics.de Git - karo-tx-linux.git/commit
freezer: fix current->state restoration race in refrigerator()
authorTejun Heo <tj@kernel.org>
Mon, 31 Oct 2011 22:30:29 +0000 (15:30 -0700)
committerTejun Heo <tj@kernel.org>
Mon, 31 Oct 2011 22:30:29 +0000 (15:30 -0700)
commitb33f5f5d0d5343aaff20cebf106fb600c5943367
tree5e93e6bf46fd96473f69f09beeef6384d6e801dc
parent839d8810747bbf39e0a5a7f223b67bffa7945f8d
freezer: fix current->state restoration race in refrigerator()

refrigerator() saves current->state before entering frozen state and
restores it before returning using __set_current_state(); however,
this is racy, for example, please consider the following sequence.

set_current_state(TASK_INTERRUPTIBLE);
try_to_freeze();
if (kthread_should_stop())
break;
schedule();

If kthread_stop() races with ->state restoration, the restoration can
restore ->state to TASK_INTERRUPTIBLE after kthread_stop() sets it to
TASK_RUNNING but kthread_should_stop() may still see zero
->should_stop because there's no memory barrier between restoring
TASK_INTERRUPTIBLE and kthread_should_stop() test.

This isn't restricted to kthread_should_stop().  current->state is
often used in memory barrier based synchronization and silently
restoring it w/o mb breaks them.

Use set_current_state() instead.

Signed-off-by: Tejun Heo <tj@kernel.org>
kernel/freezer.c