]> git.karo-electronics.de Git - karo-tx-linux.git/commit
tcp: Increase TCP_MAXSEG socket option minimum.
authorDavid S. Miller <davem@davemloft.net>
Thu, 11 Nov 2010 05:35:37 +0000 (21:35 -0800)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 7 Jan 2011 21:58:25 +0000 (13:58 -0800)
commitb4b3549b743a59b62a9324d2c9fa59a5f6bf00b3
tree3d9b7df8c12a2643bfddeb6a8fa154e3e5448ce3
parenta20c23951bb8ec4fb95261ed18d455c3182c6c29
tcp: Increase TCP_MAXSEG socket option minimum.

[ Upstream commit 7a1abd08d52fdeddb3e9a5a33f2f15cc6a5674d2 ]

As noted by Steve Chen, since commit
f5fff5dc8a7a3f395b0525c02ba92c95d42b7390 ("tcp: advertise MSS
requested by user") we can end up with a situation where
tcp_select_initial_window() does a divide by a zero (or
even negative) mss value.

The problem is that sometimes we effectively subtract
TCPOLEN_TSTAMP_ALIGNED and/or TCPOLEN_MD5SIG_ALIGNED from the mss.

Fix this by increasing the minimum from 8 to 64.

Reported-by: Steve Chen <schen@mvista.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/ipv4/tcp.c