]> git.karo-electronics.de Git - karo-tx-linux.git/commit
[media] v4l: vsp1: Stop the pipeline upon the first STREAMOFF
authorLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Sat, 18 Jun 2016 00:03:29 +0000 (21:03 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Tue, 28 Jun 2016 15:04:18 +0000 (12:04 -0300)
commitb4dfb9b35a192f555d76fc4f670a447657bcc183
tree432a3b27489ff1c9983c23bd1fb24a22f05df75c
parenteb9163d3bd2700ea3c6570a07e7548f678211dac
[media] v4l: vsp1: Stop the pipeline upon the first STREAMOFF

The device is stopped when STREAMOFF is called on the last video node in
the pipeline. This results in possible memory corruption and/or crashes,
as userspace could free buffers while the hardware is still writing to
them, and the frame completion interrupt handler could try to access
buffers that don't exist anymore.

Fix this by stopping the pipeline upon the first STREAMOFF call, not the
last.

Reported-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/platform/vsp1/vsp1_video.c