]> git.karo-electronics.de Git - karo-tx-linux.git/commit
xfrm: Fix memory leak of aead algorithm name
authorIlan Tayari <ilant@mellanox.com>
Sun, 18 Sep 2016 07:42:53 +0000 (07:42 +0000)
committerSteffen Klassert <steffen.klassert@secunet.com>
Mon, 19 Sep 2016 10:08:58 +0000 (12:08 +0200)
commitb588479358ce26f32138e0f0a7ab0678f8e3e601
treedbf7ad4ec9e4c8968d6119cfd8433821248a40ab
parent1fb81e09d487656aa23f2acb1232c7f56b4c2367
xfrm: Fix memory leak of aead algorithm name

commit 1a6509d99122 ("[IPSEC]: Add support for combined mode algorithms")
introduced aead. The function attach_aead kmemdup()s the algorithm
name during xfrm_state_construct().
However this memory is never freed.
Implementation has since been slightly modified in
commit ee5c23176fcc ("xfrm: Clone states properly on migration")
without resolving this leak.
This patch adds a kfree() call for the aead algorithm name.

Fixes: 1a6509d99122 ("[IPSEC]: Add support for combined mode algorithms")
Signed-off-by: Ilan Tayari <ilant@mellanox.com>
Acked-by: Rami Rosen <roszenrami@gmail.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
net/xfrm/xfrm_state.c