]> git.karo-electronics.de Git - karo-tx-linux.git/commit
usermodehelper: kill the sub_info->path[0] check
authorOleg Nesterov <oleg@redhat.com>
Fri, 7 Jun 2013 00:09:38 +0000 (10:09 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Mon, 17 Jun 2013 08:20:23 +0000 (18:20 +1000)
commitb5eb064f5a5117d1a05aff1b6f8de09f5edfdc92
treee879a4fc7ba73ca1093e3b4766aa9c42a48b5a15
parent5a60cf2e9da7da820c1cac3ab179be55452e9095
usermodehelper: kill the sub_info->path[0] check

call_usermodehelper_exec() does nothing but returns success if path[0] ==
0.  The only user which needs this strange feature is request_module(), it
can check modprobe_path[0] itself like other users do if they want to
detect the "disabled by admin" case.

Kill it.  Not only it looks strange, it can confuse other callers.  And
this allows us to revert 264b83c0 ("usermodehelper: check
subprocess_info->path != NULL"), do_execve(NULL) is safe.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Rusty Russell <rusty@rustcorp.com.au>
Cc: Lucas De Marchi <lucas.de.marchi@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
kernel/kmod.c