]> git.karo-electronics.de Git - karo-tx-linux.git/commit
ALSA: aloop - add locking to timer access
authorOmair Mohammed Abdullah <omair.m.abdullah@linux.intel.com>
Sat, 29 Sep 2012 06:54:05 +0000 (12:24 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 12 Oct 2012 20:50:26 +0000 (05:50 +0900)
commitb719c952c5d6d24df15f8506f5b440a760b481a0
treeed9c9640f7ab9354f60a8b720499d6c3bf6e933d
parenta49679795f592ab764fab31bd94ce533a2e3395d
ALSA: aloop - add locking to timer access

commit d4f1e48bd11e3df6a26811f7a1f06c4225d92f7d upstream.

When the loopback timer handler is running, calling del_timer() (for STOP
trigger) will not wait for the handler to complete before deactivating the
timer. The timer gets rescheduled in the handler as usual. Then a subsequent
START trigger will try to start the timer using add_timer() with a timer pending
leading to a kernel panic.

Serialize the calls to add_timer() and del_timer() using a spin lock to avoid
this.

Signed-off-by: Omair Mohammed Abdullah <omair.m.abdullah@linux.intel.com>
Signed-off-by: Vinod Koul <vinod.koul@linux.intel.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/drivers/aloop.c