]> git.karo-electronics.de Git - karo-tx-linux.git/commit
[media] media: Add obj_type field to struct media_entity
authorLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Mon, 29 Feb 2016 11:45:44 +0000 (08:45 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Wed, 13 Apr 2016 20:20:22 +0000 (17:20 -0300)
commitb76a2a8cb6f6d9da711305d805156b40c698e94f
tree7be5f0de33da38490195ce34e7eadec187c1d087
parent1d260123cb5c88574de9b5147eddc243f83b77a8
[media] media: Add obj_type field to struct media_entity

Code that processes media entities can require knowledge of the
structure type that embeds a particular media entity instance in order
to cast the entity to the proper object type. This needs is shown by the
presence of the is_media_entity_v4l2_io and is_media_entity_v4l2_subdev
functions.

The implementation of those two functions relies on the entity function
field, which is both a wrong and an inefficient design, without even
mentioning the maintenance issue involved in updating the functions
every time a new entity function is added. Fix this by adding add an
obj_type field to the media entity structure to carry the information.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/v4l2-core/v4l2-dev.c
drivers/media/v4l2-core/v4l2-subdev.c
include/media/media-entity.h