]> git.karo-electronics.de Git - karo-tx-linux.git/commit
phy-twl4030-usb: initialize charging-related stuff via pm_runtime
authorAndreas Kemnade <andreas@kemnade.info>
Wed, 24 Aug 2016 22:27:59 +0000 (00:27 +0200)
committerKishon Vijay Abraham I <kishon@ti.com>
Wed, 14 Sep 2016 05:29:12 +0000 (10:59 +0530)
commitb78ea84a7d45b9e5ad2eee429a2140065a39d755
treee588a7b3dc161cca048fe551533cc1973e90a31b
parent78489c7c48d462c2a4fa9f388dd091f829573b64
phy-twl4030-usb: initialize charging-related stuff via pm_runtime

twl4030_phy_power_on() initializes some bits which are required for
charging. As they are not set in twl4030_usb_runtime_resume()
a call to pm_runtime_get_sync() is not sufficient to enable charging.

This patch moves the initialization to twl4030_usb_runtime_resume()
so everything needed for charging is initialized upon
pm_runtime_get_sync().

That also gives improved possibilities to debug problems in that area
because the relevant parts can be checked separately. Charging can be
enabled without having the musb subsystem active.

As a side effect this hides some bugs in musb which causes
unbalanced calls to phy_power_off()/phy_power_on() so that
phy->power_count becomes -1.

The result is that e.g. the GTA04 phone (dm3730 + twl4030) works
finally as a usb gadget again and charging is working.

Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
drivers/phy/phy-twl4030-usb.c