]> git.karo-electronics.de Git - karo-tx-linux.git/commit
exec: copy-and-paste the fixes into compat_do_execve() paths
authorOleg Nesterov <oleg@redhat.com>
Tue, 30 Nov 2010 19:56:02 +0000 (20:56 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 9 Dec 2010 21:32:57 +0000 (13:32 -0800)
commitb7d121bbfa6b005a07cdb4bf2c81f9f983376dab
treef664242277d9a21b9eba13e2f9a085b1a2ad36c1
parent35cc70fc58822eff26b1c3f680244233f4fc09a5
exec: copy-and-paste the fixes into compat_do_execve() paths

commit 114279be2120a916e8a04feeb2ac976a10016f2f upstream.

Note: this patch targets 2.6.37 and tries to be as simple as possible.
That is why it adds more copy-and-paste horror into fs/compat.c and
uglifies fs/exec.c, this will be cleanuped later.

compat_copy_strings() plays with bprm->vma/mm directly and thus has
two problems: it lacks the RLIMIT_STACK check and argv/envp memory
is not visible to oom killer.

Export acct_arg_size() and get_arg_page(), change compat_copy_strings()
to use get_arg_page(), change compat_do_execve() to do acct_arg_size(0)
as do_execve() does.

Add the fatal_signal_pending/cond_resched checks into compat_count() and
compat_copy_strings(), this matches the code in fs/exec.c and certainly
makes sense.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
fs/compat.c
fs/exec.c
include/linux/binfmts.h