]> git.karo-electronics.de Git - karo-tx-linux.git/commit
svcrpc: document lack of some memory barriers
authorKosuke Tatsukawa <tatsu@ab.jp.nec.com>
Fri, 9 Oct 2015 01:44:07 +0000 (01:44 +0000)
committerJ. Bruce Fields <bfields@redhat.com>
Fri, 23 Oct 2015 20:46:09 +0000 (16:46 -0400)
commitb805ca58a81a8e408b9ebcacd023e5c6d5d2475e
treea1d844fd4cf718e00eb90742ffd2df43bdd27817
parent55b3f989410b24c3189a7ec26375c2bb519e6a1e
svcrpc: document lack of some memory barriers

We're missing memory barriers in net/sunrpc/svcsock.c in some spots we'd
expect them.  But it doesn't appear they're necessary in our case, and
this is likely a hot path--for now just document the odd behavior.

I found this issue when I was looking through the linux source code
for places calling waitqueue_active() before wake_up*(), but without
preceding memory barriers, after sending a patch to fix a similar
issue in drivers/tty/n_tty.c  (Details about the original issue can be
found here: https://lkml.org/lkml/2015/9/28/849).

Signed-off-by: Kosuke Tatsukawa <tatsu@ab.jp.nec.com>
[bfields@redhat.com,nfbrown@novell.com: document instead of adding barriers]
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
net/sunrpc/svcsock.c