]> git.karo-electronics.de Git - karo-tx-linux.git/commit
net: mvmdio: add select PHYLIB
authorThomas Petazzoni <thomas.petazzoni@free-electrons.com>
Sat, 13 Apr 2013 06:18:56 +0000 (06:18 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 1 May 2013 16:46:19 +0000 (09:46 -0700)
commitbb0fc43840dfbeb4f91d5fdd217449ad72b5d70d
tree0076f5f63d0d748a964d1b43947b31a7d1b3d4fc
parent59c5ccaa37238605cbe11202c7d4f811db363aeb
net: mvmdio: add select PHYLIB

[ Upstream commit 2e0cbf2cc2c9371f0aa198857d799175ffe231a6 ]

The mvmdio driver uses the phylib API, so it should select the PHYLIB
symbol, otherwise, a build with mvmdio (but without mvneta) fails to
build with undefined symbols such as mdiobus_unregister, mdiobus_free,
etc.

The mvneta driver does not use the phylib API directly, so it does not
need to select PHYLIB. It already selects the mvmdio driver anyway.

Historically, this problem is due to the fact that the PHY handling
was originally part of mvneta, and was later moved to a separate
driver, without updating the Kconfig select statements
accordingly. And since there was no functional reason to use mvmdio
without mvneta, this case was not tested.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/marvell/Kconfig