]> git.karo-electronics.de Git - karo-tx-linux.git/commit
My load tests on PowerPC freeze within minutes in __slab_free(). I
authorHugh Dickins <hughd@google.com>
Tue, 26 Jul 2011 10:14:35 +0000 (20:14 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Mon, 1 Aug 2011 03:36:26 +0000 (13:36 +1000)
commitbb9b320a1115f22de07b2e1ff77842548f26d706
tree607bf60b8fe8fba0f212f77c0ad833a1901cabb2
parent841021cfb0bdc8341d3f03d4d2fa0a3082e94a8a
My load tests on PowerPC freeze within minutes in __slab_free().  I
happened to try PPC first, didn't try without this fix on x86.

It looks as if the author was interrupted while devising the new
cmpxchg_double_slab() version of __slab_free(): its decision to
spin_lock_irqsave() depends on several uninitialized fields, and fixing
that (by copying page to new) mostly fixes it.

But I didn't think about it very much, and this may well not be what the
author intends; and I have seen a couple of much rarer freezes in
__slab_free() on PPC (not yet on x86) even after applying this.

Signed-off-by: Hugh Dickins <hughd@google.com>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Christoph Lameter <cl@linux.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/slub.c