]> git.karo-electronics.de Git - karo-tx-linux.git/commit
tcp: Fix >4GB writes on 64-bit.
authorDavid S. Miller <davem@davemloft.net>
Tue, 28 Sep 2010 03:24:54 +0000 (20:24 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 21 Mar 2011 19:43:21 +0000 (12:43 -0700)
commitbb9ec4584b3afa1ab0a9b8d6060fe08a3290ea4d
treecb6d98a70d81ae9b6fc2f775b7531caa449ae6c4
parentab274fcfec82a91a6232ac71d620b62beb80ef78
tcp: Fix >4GB writes on 64-bit.

[ Upstream commit 01db403cf99f739f86903314a489fb420e0e254f ]

Fixes kernel bugzilla #16603

tcp_sendmsg() truncates iov_len to an 'int' which a 4GB write to write
zero bytes, for example.

There is also the problem higher up of how verify_iovec() works.  It
wants to prevent the total length from looking like an error return
value.

However it does this using 'int', but syscalls return 'long' (and
thus signed 64-bit on 64-bit machines).  So it could trigger
false-positives on 64-bit as written.  So fix it to use 'long'.

Reported-by: Olaf Bonorden <bono@onlinehome.de>
Reported-by: Daniel Büse <dbuese@gmx.de>
Reported-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
include/linux/socket.h
net/core/iovec.c
net/ipv4/tcp.c