]> git.karo-electronics.de Git - karo-tx-linux.git/commit
iscsi-target: Fix ABORT_TASK + connection reset iscsi_queue_req memory leak
authorNicholas Bellinger <nab@linux-iscsi.org>
Tue, 10 Jun 2014 04:03:54 +0000 (04:03 +0000)
committerNicholas Bellinger <nab@linux-iscsi.org>
Tue, 10 Jun 2014 04:20:57 +0000 (04:20 +0000)
commitbbc050488525e1ab1194c27355f63c66814385b8
treee52941b8284958c1e147962ab901d19dca971f78
parenta95d6511303b848da45ee27b35018bb58087bdc6
iscsi-target: Fix ABORT_TASK + connection reset iscsi_queue_req memory leak

This patch fixes a iscsi_queue_req memory leak when ABORT_TASK response
has been queued by TFO->queue_tm_rsp() -> lio_queue_tm_rsp() after a
long standing I/O completes, but the connection has already reset and
waiting for cleanup to complete in iscsit_release_commands_from_conn()
-> transport_generic_free_cmd() -> transport_wait_for_tasks() code.

It moves iscsit_free_queue_reqs_for_conn() after the per-connection command
list has been released, so that the associated se_cmd tag can be completed +
released by target-core before freeing any remaining iscsi_queue_req memory
for the connection generated by lio_queue_tm_rsp().

Cc: Thomas Glanzmann <thomas@glanzmann.de>
Cc: Charalampos Pournaris <charpour@gmail.com>
Cc: stable@vger.kernel.org # 3.10+
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/iscsi/iscsi_target.c