]> git.karo-electronics.de Git - linux-beck.git/commit
isdn: avoid calling tty_ldisc_flush() in atomic context
authorTilman Schmidt <tilman@imap.cc>
Mon, 5 Jul 2010 14:18:27 +0000 (14:18 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 6 Jul 2010 02:41:23 +0000 (19:41 -0700)
commitbc10f96757bd6ab3721510df8defa8f21c32f974
tree35d5ec90646cc73952287ee006d92e58e793a0fd
parent831334cbbbdc2b2923513104e6e70c80dda0bff0
isdn: avoid calling tty_ldisc_flush() in atomic context

Remove the call to tty_ldisc_flush() from the RESULT_NO_CARRIER
branch of isdn_tty_modem_result(), as already proposed in commit
00409bb045887ec5e7b9e351bc080c38ab6bfd33.
This avoids a "sleeping function called from invalid context" BUG
when the hardware driver calls the statcallb() callback with
command==ISDN_STAT_DHUP in atomic context, which in turn calls
isdn_tty_modem_result(RESULT_NO_CARRIER, ~), and from there,
tty_ldisc_flush() which may sleep.

Signed-off-by: Tilman Schmidt <tilman@imap.cc>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/isdn/i4l/isdn_tty.c