]> git.karo-electronics.de Git - karo-tx-linux.git/commit
ide: Fix IDE taskfile with cfq scheduler
authorMikulas Patocka <mpatocka@redhat.com>
Tue, 6 Apr 2010 23:43:33 +0000 (16:43 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 2 Aug 2010 17:20:52 +0000 (10:20 -0700)
commitbc823014630b05fb2deb5cf0a15032de63c41d89
treedf82b0f0a83e5b7354dc36898d597bc70956bf2e
parentd3e7eb80772f1b39065906313113a892a6c65867
ide: Fix IDE taskfile with cfq scheduler

commit 720fc22a7af79d91ec460c80efa92c65c12d105e upstream.

When ide taskfile access is being used (for example with hdparm --security
commands) and cfq scheduler is selected, the scheduler crashes on BUG in
cfq_put_request.

The reason is that the cfq scheduler is tracking counts of read and write
requests separately; the ide-taskfile subsystem allocates a read request and
then flips the flag to make it a write request. The counters in cfq will
mismatch.

This patch changes ide-taskfile to allocate the READ or WRITE request as
required and don't change the flag later.

Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/ide/ide-taskfile.c