]> git.karo-electronics.de Git - karo-tx-linux.git/commit
UBIFS: do not read flash unnecessarily
authorArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
Fri, 25 Mar 2011 16:33:57 +0000 (18:33 +0200)
committerPaul Gortmaker <paul.gortmaker@windriver.com>
Wed, 14 Mar 2012 14:56:59 +0000 (10:56 -0400)
commitbcdf4fed726fd61b9d6b009a933269dca5b75d5d
tree836fdf2d05a0fb146d052b96179407137e47449f
parentedf08a7ef1a4854bd63d77a7a55ea9f1480c8558
UBIFS: do not read flash unnecessarily

commit 8b229c76765816796eec7ccd428f03bd8de8b525 upstream.

This fix makes the 'dbg_check_old_index()' function return
immediately if debugging is disabled, instead of executing
incorrect 'goto out' which causes UBIFS to:

1. Allocate memory
2. Read the flash

On every commit. OK, we do not commit that often, but it is
still silly to do unneeded I/O anyway.

Credits to coverity for spotting this silly issue.

Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
fs/ubifs/commit.c