]> git.karo-electronics.de Git - karo-tx-linux.git/commit
s390/monwriter: fix smatch warning for strcpy()
authorGerald Schaefer <gerald.schaefer@de.ibm.com>
Mon, 14 Oct 2013 13:51:31 +0000 (15:51 +0200)
committerMartin Schwidefsky <schwidefsky@de.ibm.com>
Thu, 17 Oct 2013 07:26:18 +0000 (09:26 +0200)
commitbec5fa2796173bf4d08d5032d4fae87c4494f209
treea9e46495d507b536f3502f54a51deba77b776f06
parentd658642aa02f3d8b7ffa42346d4dd29ba0026627
s390/monwriter: fix smatch warning for strcpy()

This patch fixes the following smatch warning:
monwrite_diag() error: strcpy() '"LNXAPPL"' too large for 'id.prod_nr'
(8 vs 7)
Using strcpy() is wrong, because it also copies the terminating null
byte, but in this case the extra copied null byte will be overwritten
right after the strcpy(), so there is no real problem here.
Use strncpy() to fix the warning.

Signed-off-by: Gerald Schaefer <gerald.schaefer@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
drivers/s390/char/monwriter.c