]> git.karo-electronics.de Git - karo-tx-linux.git/commit
x86: Use u32 instead of long to set reset vector back to 0
authorDon Zickus <dzickus@redhat.com>
Tue, 8 Feb 2011 04:25:00 +0000 (23:25 -0500)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 7 Mar 2011 23:17:53 +0000 (15:17 -0800)
commitbf30c46aba4aecb1a289ed3249b46e6091b6f7b2
tree306daa5e48e3cd1c47ce66445163d78d9168e8d4
parentba7c5cae3c3b1d2ca1e78716806d8a386b569b0a
x86: Use u32 instead of long to set reset vector back to 0

commit 299c56966a72b9109d47c71a6db52097098703dd upstream.

A customer of ours, complained that when setting the reset
vector back to 0, it trashed other data and hung their box.
They noticed when only 4 bytes were set to 0 instead of 8,
everything worked correctly.

Mathew pointed out:

 |
 | We're supposed to be resetting trampoline_phys_low and
 | trampoline_phys_high here, which are two 16-bit values.
 | Writing 64 bits is definitely going to overwrite space
 | that we're not supposed to be touching.
 |

So limit the area modified to u32.

Signed-off-by: Don Zickus <dzickus@redhat.com>
Acked-by: Matthew Garrett <mjg@redhat.com>
LKML-Reference: <1297139100-424-1-git-send-email-dzickus@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
arch/x86/include/asm/smpboot_hooks.h