]> git.karo-electronics.de Git - karo-tx-linux.git/commit
m68k/uaccess: Fix asm constraints for userspace access
authorGeert Uytterhoeven <geert@linux-m68k.org>
Sun, 9 Jun 2013 18:12:42 +0000 (20:12 +0200)
committerGeert Uytterhoeven <geert@linux-m68k.org>
Sun, 16 Jun 2013 12:02:29 +0000 (14:02 +0200)
commitbf58349983c07fc2e18d74688a8df7e02290d1f0
treecc1d0648e04d2fe54d0814b3afcb2caf6c61da16
parent2240cee33b441eef204c9e1f77555a07f16eb59c
m68k/uaccess: Fix asm constraints for userspace access

When compiling a MMU kernel with CPU_HAS_ADDRESS_SPACES=n (e.g. "MMU=y
allnoconfig": "echo CONFIG_MMU=y > allno.config && make KCONFIG_ALLCONFIG=1
allnoconfig"), we use plain "move" instead of "moves", and I got:

  CC      arch/m68k/lib/uaccess.o
{standard input}: Assembler messages:
{standard input}:47: Error: operands mismatch -- statement `move.b %a0,(%a1)' ignored

This happens because plain "move" doesn't support byte transfers between
memory and address registers, while "moves" does.

Fix the asm constraints for __generic_copy_from_user(),
__generic_copy_to_user(), and __clear_user() to only use data registers
when accessing userspace.

Also, relax the asm constraints for 16-bit userspace accesses in
__put_user() and __get_user(), as both "move" and "moves" do support
such transfers between memory and address registers.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
arch/m68k/include/asm/uaccess_mm.h
arch/m68k/lib/uaccess.c